Yushario
日本語ENStart your adventure
Docs/Basics

Review the changes

When a report arrives, check the real code changes and the verification marks.

Before you start A report has arrived

When a hero's report arrives, do not judge by the reply text alone. Look at the actual code changes. Look at the changes (review) on the quest card opens the view for that.

Open the review#

When a report arrives, the Next box says a report has arrived and asks you to look at the changes. Select Look at the changes (review).

The review view with a file list on the left and changes in red and green on the right.
The code and file names are fictional, for illustration. (Select the image to open it full size.)
  1. Check the range being compared

    Choose uncommitted changes or the whole branch. For the whole branch, check what it is compared against.

  2. Pick a file on the left

    See whether it was added, changed or deleted, and how many lines moved.

  3. Read the change on the right

    Red is removed, green is added. If something needs fixing, use "Needs changes" in the review or "Ask for another try" on the card.

The verification marks#

The marks under the card show results against your acceptance checks. They are based on run results and work state delivered by hooks, and they distinguish five states.

MarkMeaning
Not runNot run yet
PassedRan and passed
FailedRan and failed
Changed sinceThe code changed after the check, so the result may be stale
UnknownThe result could not be obtained or judged
Do not read Unknown or Not run as a pass

Registering a check does not run the command. Complex commands and results that cannot be obtained show as Unknown. With Codex hooks, no automatic verification evidence is produced.

When you are satisfied, move on to Adopt the result.